Fix ansible-lint rule violations

This commit is contained in:
ansible-code-bot[bot]
2024-09-11 20:13:03 +00:00
parent 03c8025a68
commit 9dd769e6b8
18 changed files with 126 additions and 132 deletions

View File

@@ -7,11 +7,11 @@
tasks: tasks:
- name: Create resource group - name: Create resource group
azure.azcollection.azure_rm_resourcegroup: azure.azcollection.azure_rm_resourcegroup:
name: "webserver_{{ user }}" name: webserver_{{ user }}
location: northeurope location: northeurope
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
register: rg register: rg
- name: Show RG - name: Show RG
ansible.builtin.debug: ansible.builtin.debug:

View File

@@ -7,11 +7,11 @@
tasks: tasks:
- name: Create resource group - name: Create resource group
azure.azcollection.azure_rm_resourcegroup: azure.azcollection.azure_rm_resourcegroup:
name: "webserver_{{ user }}" name: webserver_{{ user }}
location: northeurope location: northeurope
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
register: rg register: rg
- name: Show RG - name: Show RG
ansible.builtin.debug: ansible.builtin.debug:

View File

@@ -7,12 +7,10 @@
ansible.builtin.debug: ansible.builtin.debug:
msg: "{{ ansible_facts }}" msg: "{{ ansible_facts }}"
- name: Debug Facts Hostname - Unsafe Text - name: Debug Facts Hostname - Unsafe Text
ansible.builtin.debug: ansible.builtin.debug:
msg: "{{ ansible_facts['nodename'] }}" msg: "{{ ansible_facts['nodename'] }}"
- name: Debug Facts ipv4 - List - name: Debug Facts ipv4 - List
ansible.builtin.debug: ansible.builtin.debug:
msg: "{{ ansible_facts['all_ipv4_addresses'][0] }}" msg: "{{ ansible_facts['all_ipv4_addresses'][0] }}"

View File

@@ -8,8 +8,7 @@
ansible.builtin.file: ansible.builtin.file:
path: /root/testfile.txt path: /root/testfile.txt
state: touch state: touch
mode: '0755' mode: "0755"
- name: Add line in file - name: Add line in file
ansible.builtin.lineinfile: ansible.builtin.lineinfile:

View File

@@ -19,8 +19,8 @@
name: "{{ item.name }}" name: "{{ item.name }}"
group: "{{ item.groups }}" group: "{{ item.groups }}"
loop: loop:
- { name: 'homer', groups: 'Developers' } - { name: homer, groups: Developers }
- { name: 'bart', groups: 'It' } - { name: bart, groups: It }
- { name: 'lisa', groups: 'Management' } - { name: lisa, groups: Management }
- { name: 'ned', groups: 'Finance' } - { name: ned, groups: Finance }
- { name: 'moe', groups: 'Developers' } - { name: moe, groups: Developers }

View File

@@ -4,4 +4,4 @@
become: true become: true
roles: roles:
- jesperberth.el_httpd - jesperberth.el_httpd

View File

@@ -17,7 +17,7 @@
ansible.builtin.get_url: ansible.builtin.get_url:
url: https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip url: https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip
dest: ~/awscliv2.zip dest: ~/awscliv2.zip
mode: '0700' mode: "0700"
when: not awsfile.stat.exists when: not awsfile.stat.exists
- name: Unzip aws-cli - name: Unzip aws-cli

View File

@@ -41,13 +41,12 @@
rescue: rescue:
- name: Print when errors - name: Print when errors
ansible.builtin.debug: ansible.builtin.debug:
msg: 'There is an error in this block)' msg: There is an error in this block)
always: always:
- name: Always do this - name: Always do this
ansible.builtin.debug: ansible.builtin.debug:
msg: "Will always run" msg: Will always run
- name: Configure firewall - name: Configure firewall
ansible.posix.firewalld: ansible.posix.firewalld:
@@ -60,7 +59,6 @@
- firewall - firewall
- config - config
handlers: handlers:
- name: Firewall reload - name: Firewall reload
ansible.builtin.systemd: ansible.builtin.systemd:

View File

@@ -3,8 +3,8 @@
hosts: tag_solution_webserver_alex hosts: tag_solution_webserver_alex
become: true become: true
vars: vars:
websiteheader: "Ansible Playbook" websiteheader: Ansible Playbook
websiteauthor: "Alex" websiteauthor: Alex
tasks: tasks:
- name: Install Apache - name: Install Apache

View File

@@ -5,10 +5,10 @@
vars: vars:
user: alex user: alex
location: northeurope location: northeurope
virtual_network_name: "webserver_{{ user }}" virtual_network_name: webserver_{{ user }}
subnet: Webserver subnet: Webserver
resource_group: "webserver_{{ user }}" resource_group: webserver_{{ user }}
domain_sub: "domain{{ user }}" domain_sub: domain{{ user }}
ssh_public_key: "{{lookup('file', '~/.ssh/id_rsa.pub') }}" ssh_public_key: "{{lookup('file', '~/.ssh/id_rsa.pub') }}"
tasks: tasks:
@@ -16,76 +16,75 @@
azure.azcollection.azure_rm_virtualnetwork: azure.azcollection.azure_rm_virtualnetwork:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: "{{ virtual_network_name }}" name: "{{ virtual_network_name }}"
address_prefixes_cidr: "10.99.0.0/16" address_prefixes_cidr: 10.99.0.0/16
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Create a subnet - name: Create a subnet
azure.azcollection.azure_rm_subnet: azure.azcollection.azure_rm_subnet:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
virtual_network_name: "{{ virtual_network_name }}" virtual_network_name: "{{ virtual_network_name }}"
name: "{{ subnet }}" name: "{{ subnet }}"
address_prefix_cidr: "10.99.0.0/24" address_prefix_cidr: 10.99.0.0/24
- name: Create a public ip address for webserver - name: Create a public ip address for webserver
azure_rm_publicipaddress: register: webserver_pub_ip
azure.azcollection.azure_rm_publicipaddress:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: public_ip_webserver name: public_ip_webserver
allocation_method: static allocation_method: static
domain_name: "webserver{{ domain_sub }}" domain_name: webserver{{ domain_sub }}
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
register: webserver_pub_ip
- name: Create Security Group for webserver - name: Create Security Group for webserver
azure_rm_securitygroup: azure.azcollection.azure_rm_securitygroup:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: "webserver_securitygroup" name: webserver_securitygroup
purge_rules: true purge_rules: true
rules: rules:
- name: Allow_SSH - name: Allow_SSH
protocol: Tcp protocol: Tcp
destination_port_range: 22 destination_port_range: 22
access: Allow access: Allow
priority: 100 priority: 100
direction: Inbound direction: Inbound
- name: Allow_HTTP - name: Allow_HTTP
protocol: Tcp protocol: Tcp
destination_port_range: 80 destination_port_range: 80
access: Allow access: Allow
priority: 101 priority: 101
direction: Inbound direction: Inbound
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Create a network interface for webserver - name: Create a network interface for webserver
azure_rm_networkinterface: azure.azcollection.azure_rm_networkinterface:
name: "webserver_nic01" name: webserver_nic01
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
virtual_network: "{{ virtual_network_name }}" virtual_network: "{{ virtual_network_name }}"
subnet_name: "{{ subnet }}" subnet_name: "{{ subnet }}"
security_group: "webserver_securitygroup" security_group: webserver_securitygroup
ip_configurations: ip_configurations:
- name: "webserver_nic01_ipconfig" - name: webserver_nic01_ipconfig
public_ip_address_name: "public_ip_webserver" public_ip_address_name: public_ip_webserver
primary: True primary: true
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Create a VM webserver - name: Create a VM webserver
azure_rm_virtualmachine: azure.azcollection.azure_rm_virtualmachine:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: "webserver" name: webserver
os_type: Linux os_type: Linux
admin_username: "{{ user }}" admin_username: "{{ user }}"
ssh_password_enabled: false ssh_password_enabled: false
ssh_public_keys: ssh_public_keys:
- path: "/home/{{ user }}/.ssh/authorized_keys" - path: /home/{{ user }}/.ssh/authorized_keys
key_data: "{{ ssh_public_key }}" key_data: "{{ ssh_public_key }}"
managed_disk_type: Standard_LRS managed_disk_type: Standard_LRS
state: present state: present
@@ -95,13 +94,13 @@
sku: "8_4" sku: "8_4"
version: latest version: latest
vm_size: Standard_A1_v2 vm_size: Standard_A1_v2
network_interfaces: "webserver_nic01" network_interfaces: webserver_nic01
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Show webserver public ip - name: Show webserver public ip
debug: ansible.builtin.debug:
msg: "{{ webserver_pub_ip.state.ip_address }}" msg: "{{ webserver_pub_ip.state.ip_address }}"
- name: Wait for ssh on webserver - name: Wait for ssh on webserver
@@ -112,4 +111,4 @@
timeout: 600 timeout: 600
- name: Add webserver to ssh known_hosts - name: Add webserver to ssh known_hosts
shell: "ssh-keyscan -t ecdsa {{ webserver_pub_ip.state.ip_address }} >> /home/{{ user }}/.ssh/known_hosts" ansible.builtin.shell: ssh-keyscan -t ecdsa {{ webserver_pub_ip.state.ip_address }} >> /home/{{ user }}/.ssh/known_hosts

View File

@@ -5,87 +5,85 @@
vars: vars:
user: alex user: alex
location: northeurope location: northeurope
virtual_network_name: "webserver_{{ user }}" virtual_network_name: webserver_{{ user }}
subnet: Webserver subnet: Webserver
resource_group: "webserver_{{ user }}" resource_group: webserver_{{ user }}
domain_sub: "domain{{ user }}" domain_sub: domain{{ user }}
tasks: tasks:
- name: Create a virtual network - name: Create a virtual network
azure.azcollection.azure_rm_virtualnetwork: azure.azcollection.azure_rm_virtualnetwork:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: "{{ virtual_network_name }}" name: "{{ virtual_network_name }}"
address_prefixes_cidr: "10.99.0.0/16" address_prefixes_cidr: 10.99.0.0/16
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Create a subnet - name: Create a subnet
azure.azcollection.azure_rm_subnet: azure.azcollection.azure_rm_subnet:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
virtual_network_name: "{{ virtual_network_name }}" virtual_network_name: "{{ virtual_network_name }}"
name: "{{ subnet }}" name: "{{ subnet }}"
address_prefix_cidr: "10.99.0.0/24" address_prefix_cidr: 10.99.0.0/24
- name: Create a public ip address for webserver - name: Create a public ip address for webserver
azure_rm_publicipaddress: register: webserver_pub_ip
azure.azcollection.azure_rm_publicipaddress:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: public_ip_webserver name: public_ip_webserver
allocation_method: static allocation_method: static
domain_name: "webserver{{ domain_sub }}" domain_name: webserver{{ domain_sub }}
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
register: webserver_pub_ip
- name: Create Security Group for webserver - name: Create Security Group for webserver
azure_rm_securitygroup: azure.azcollection.azure_rm_securitygroup:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: "webserver_securitygroup" name: webserver_securitygroup
purge_rules: true purge_rules: true
rules: rules:
- name: Allow_SSH - name: Allow_SSH
protocol: Tcp protocol: Tcp
destination_port_range: 22 destination_port_range: 22
access: Allow access: Allow
priority: 100 priority: 100
direction: Inbound direction: Inbound
- name: Allow_HTTP - name: Allow_HTTP
protocol: Tcp protocol: Tcp
destination_port_range: 80 destination_port_range: 80
access: Allow access: Allow
priority: 101 priority: 101
direction: Inbound direction: Inbound
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Create a network interface for webserver - name: Create a network interface for webserver
azure_rm_networkinterface: azure.azcollection.azure_rm_networkinterface:
name: "webserver_nic01" name: webserver_nic01
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
virtual_network: "{{ virtual_network_name }}" virtual_network: "{{ virtual_network_name }}"
subnet_name: "{{ subnet }}" subnet_name: "{{ subnet }}"
security_group: "webserver_securitygroup" security_group: webserver_securitygroup
ip_configurations: ip_configurations:
- name: "webserver_nic01_ipconfig" - name: webserver_nic01_ipconfig
public_ip_address_name: "public_ip_webserver" public_ip_address_name: public_ip_webserver
primary: True primary: true
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Create a VM webserver - name: Create a VM webserver
azure_rm_virtualmachine: azure.azcollection.azure_rm_virtualmachine:
resource_group: "{{ resource_group }}" resource_group: "{{ resource_group }}"
name: "webserver" name: webserver
os_type: Linux os_type: Linux
admin_username: "{{ user }}" admin_username: "{{ user }}"
ssh_password_enabled: false ssh_password_enabled: false
ssh_public_keys: ssh_public_keys:
- path: "/home/{{ user }}/.ssh/authorized_keys" - path: /home/{{ user }}/.ssh/authorized_keys
key_data: "{{ ssh_public_key }}" key_data: "{{ ssh_public_key }}"
managed_disk_type: Standard_LRS managed_disk_type: Standard_LRS
state: present state: present
@@ -95,13 +93,13 @@
sku: "8_4" sku: "8_4"
version: latest version: latest
vm_size: Standard_A1_v2 vm_size: Standard_A1_v2
network_interfaces: "webserver_nic01" network_interfaces: webserver_nic01
tags: tags:
solution: "webserver_{{ user }}" solution: webserver_{{ user }}
delete: ansibletraining delete: ansibletraining
- name: Show webserver public ip - name: Show webserver public ip
debug: ansible.builtin.debug:
msg: "{{ webserver_pub_ip.state.ip_address }}" msg: "{{ webserver_pub_ip.state.ip_address }}"
- name: Wait for ssh on webserver - name: Wait for ssh on webserver

View File

@@ -19,4 +19,4 @@
password: P@ssw0rd! password: P@ssw0rd!
state: present state: present
groups: groups:
- corp - corp

View File

@@ -8,13 +8,13 @@
ansible.builtin.file: ansible.builtin.file:
path: /mnt/resource/ path: /mnt/resource/
state: directory state: directory
mode: '0755' mode: "0755"
- name: Download files - name: Download files
ansible.builtin.get_url: ansible.builtin.get_url:
url: "{{ item }}" url: "{{ item }}"
dest: /mnt/resource/ dest: /mnt/resource/
mode: '0600' mode: "0600"
loop: loop:
- https://github.com/git-for-windows/git/releases/download/v2.30.0.windows.1/Git-2.30.0-64-bit.exe - https://github.com/git-for-windows/git/releases/download/v2.30.0.windows.1/Git-2.30.0-64-bit.exe
- https://www.python.org/ftp/python/3.8.7/python-3.8.7-embed-amd64.zip - https://www.python.org/ftp/python/3.8.7/python-3.8.7-embed-amd64.zip

View File

@@ -13,4 +13,4 @@
dest: /var/www/html/index.php dest: /var/www/html/index.php
owner: root owner: root
group: root group: root
mode: '0755' mode: "0755"

View File

@@ -7,8 +7,8 @@
tasks: tasks:
- name: Delete resource group - name: Delete resource group
azure_rm_resourcegroup: azure.azcollection.azure_rm_resourcegroup:
name: "webserver_{{ user }}" name: webserver_{{ user }}
location: northeurope location: northeurope
state: absent state: absent
force_delete_nonempty: true force_delete_nonempty: true

View File

@@ -1,9 +1,9 @@
--- ---
# defaults file for webserver # defaults file for webserver
package: package:
- httpd - httpd
- mod_ssl - mod_ssl
- openssl - openssl
- php - php
- php-gd - php-gd
- php-mbstring - php-mbstring

View File

@@ -1,3 +1,4 @@
---
galaxy_info: galaxy_info:
author: Alex author: Alex
description: a role for installing a webserver description: a role for installing a webserver
@@ -44,12 +45,12 @@ galaxy_info:
- "8" - "8"
galaxy_tags: [] galaxy_tags: []
# List tags for your role here, one per line. A tag is a keyword that describes # List tags for your role here, one per line. A tag is a keyword that describes
# and categorizes the role. Users find roles by searching for tags. Be sure to # and categorizes the role. Users find roles by searching for tags. Be sure to
# remove the '[]' above, if you add tags to this list. # remove the '[]' above, if you add tags to this list.
# #
# NOTE: A tag is limited to a single word comprised of alphanumeric characters. # NOTE: A tag is limited to a single word comprised of alphanumeric characters.
# Maximum 20 tags per role. # Maximum 20 tags per role.
dependencies: [] dependencies: []
# List your role dependencies here, one per line. Be sure to remove the '[]' above, # List your role dependencies here, one per line. Be sure to remove the '[]' above,

View File

@@ -1,7 +1,8 @@
---
plugin: azure_rm plugin: azure_rm
auth_source: auto auth_source: auto
include_vm_resource_groups: include_vm_resource_groups:
- '*' - "*"
keyed_groups: keyed_groups:
- prefix: tag - prefix: tag
key: tags key: tags