From b7ce002e4e6379eea963dcd27873aaa4300eb180 Mon Sep 17 00:00:00 2001 From: alexpolo1 Date: Thu, 27 Aug 2026 06:40:15 +0200 Subject: [PATCH] =?UTF-8?q?config:=20stop=20blocking=20shield=20sales=20?= =?UTF-8?q?=E2=80=94=20130=20blocked=20sells=20clogged=20the=20pack?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit protect_shields_from_sell=1 never vendored any item with "shield" in its detected name. That is redundant safety: the EQUIPPED shield is already protected positionally by mouse._is_clicking_safe(), which cancels any click landing in ui_roi[equipped_inventory_area] while the inventory is open. The name rule only ever hit shields sitting in the inventory grid, which the pickit had already judged. Cost measured over one day: 130 blocked sells — FIEND SHIELD 64, AERIN SHIELD 41, HERALDIC SHIELD 23, plus DRAGON/ANCIENT. The same shields were re-evaluated and re-blocked every game ("Discarding FIEND SHIELD." immediately followed by "Blocked sell for protected item: FIEND SHIELD"), so they could never leave the pack and permanently occupied slots. The rare catch-all added in the pickit made this much worse, since rare shields are now picked up. Verified live after restart: "Confirmed sell 'FIEND SHIELD'" on the very item that had been blocked 64 times, followed by HATCHET HANDS, LONG SWORD, LIGHT GAUNTLETS, DEMONHIDE BOOTS and FLAIL — six sales in five minutes with zero blocks. Charm protection (protect_charms_from_sell) is left ON: charms live in the inventory by design and a misread charm cannot be un-sold. Co-Authored-By: Claude Opus 5 --- config/params.ini | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/config/params.ini b/config/params.ini index c34240b..7c71acf 100644 --- a/config/params.ini +++ b/config/params.ini @@ -369,8 +369,16 @@ repair_npc=a5_larzuk runs_per_stash=4 ; sell_junk: 1 = vendor non-keep items automatically sell_junk=1 -; protect_shields_from_sell: 1 = never vendor items with "shield" in detected name (recommended safety) -protect_shields_from_sell=1 +; protect_shields_from_sell: 1 = never vendor items with "shield" in detected name. +; DISABLED 2026-08-27. This is redundant: the EQUIPPED shield is already protected +; positionally by mouse._is_clicking_safe(), which cancels any click landing in +; ui_roi[equipped_inventory_area] while the inventory is open. The name rule only ever +; hit shields sitting in the INVENTORY grid, which the pickit had already judged. +; Cost of leaving it on: 130 blocked sells in one day (FIEND SHIELD 64, AERIN SHIELD 41, +; HERALDIC SHIELD 23...). The same shields were re-evaluated and re-blocked every single +; game — "Discarding FIEND SHIELD." then "Blocked sell for protected item: FIEND SHIELD" — +; so they could never leave the pack and permanently occupied slots. +protect_shields_from_sell=0 ; protect_charms_from_sell: 1 = never drop/vendor charms regardless of pickit verdict ; (recommended safety — a misread charm can't be un-dropped). Set to 0 to let your ; pickit rules decide keep/discard for charms same as any other item.